Skip to content

Feature - Testing with strict sql_mode #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature - Testing with strict sql_mode #490

wants to merge 9 commits into from

Conversation

Rican7
Copy link
Collaborator

@Rican7 Rican7 commented Jan 23, 2015

This PR sets the MySQL sql_mode to a strict setting for our tests.

We do this in two ways/places:

  • Set it globally for Travis-CI, since we want all travis tests to be strict and we don't care about messing with the environment since its temporary anyway
  • Set it for the session when testing locally, so that it doesn't change your local MySQL configuration semi-permanently (which may be used for other local DB's)

Setting the sql_mode in this way should make our testing more reliable and will most likely even restore the seemingly vanished bug described in #438 (that was originally fixed in #317 and then again in #440).

@koenpunt
Copy link
Collaborator

Cool, great work, can you reopen this PR against 1.1-dev?

@Rican7
Copy link
Collaborator Author

Rican7 commented Jan 23, 2015

Yea, sure.

@Rican7 Rican7 mentioned this pull request Jan 23, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testing travis/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rican7 @koenpunt